Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: run GatewayWithAttachedRoutes from Gateway API conformance suite #286

Merged
merged 2 commits into from
May 23, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented May 22, 2024

What this PR does / why we need it:

This concludes the implementation of support for setting AttachedRoutes in listeners status.

This PR also fixes the errors when running the tests on Darwin:

ld: warning: '/private/var/folders/0m/_63w01516tgf3cftmp9h7ylm0000gn/T/go-link-1798743752/000014.o' has malformed LC_DYSYMTAB, expected 98 undefined symbols to start at index 1626, found 95 undefined symbols starting at index 1626

Which issue this PR fixes

Fixes #56

Special notes for your reviewer:

Running conformance suite, I've observed errors which I've captured in Kong/kubernetes-ingress-controller#6067.

@pmalek pmalek added this to the KGO v1.3.x milestone May 22, 2024
@pmalek pmalek self-assigned this May 22, 2024
@pmalek pmalek marked this pull request as ready for review May 22, 2024 15:33
@pmalek pmalek requested a review from a team as a code owner May 22, 2024 15:33
@pmalek pmalek enabled auto-merge (squash) May 22, 2024 15:33
@pmalek pmalek merged commit 129ee4e into main May 23, 2024
14 checks passed
@pmalek pmalek deleted the gateway-api-run-attached-routes-conformance branch May 23, 2024 13:54
@pmalek pmalek mentioned this pull request Jun 18, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conformance: GatewayWithAttachedRoutes test
2 participants